Ask Your Question

Revision history [back]

My comments would be:

1) your indenting is all over the place.

2) you have a notification arrow chaining your /etc/environment to your /etc/ficr/ directory, which doesn't make any sense to me.

3) you seem to have misunderstood the purpose of the path attribute to exec resources. All you need there is /bin as the purpose is simply to allow puppet to find the binary command or commands in your command attribute.

4) the unless you refer to should indeed be (I think) just rpm -q <rpm name="">.

5) As someone said above, you should look into using the package resource type to install RPMs rather than exec.

My comments would be:

1) your indenting is all over the place.

2) you have a notification arrow chaining your /etc/environment to your /etc/ficr/ directory, which doesn't make any sense to me.

3) you seem to have misunderstood the purpose of the path attribute to exec resources. All you need there is /bin as the purpose is simply to allow puppet to find the binary command or commands in your command attribute.attribute. If you need to set resource defaults for all execs you should have a block like

Exec {
  path => '/bin',
}

4) the unless you refer to should indeed be (I think) just rpm -q <rpm name="">.

5) As someone said above, you should look into using the package resource type to install RPMs rather than exec.