Ask Your Question
0

Contribute to puppetlabs/facter

asked 2017-04-19 09:53:48 -0500

Hi there,

I am trying to make my first contribution to the puppet ecosystem. I've read the CONTRIBUTING.md but still I am not able to figure out the proper way to create a pull request. My first commit failed because of a wrong commit message format. After I fixed that it now fails with the following error message:

Failures - mingw-w64 (exited 1) - mingw-w64 not installed. An error occurred during installation: Unable to read package from path 'mingw-w64.4.8.3.nupkg'. Command exited with code 1

The only thing that I have changed is the EC2_CONNECTION_TIMEOUT from 200 to 600, because I noticed that there appears a connection-timeout on a regular basis when working with auto-scaling groups.

I am creating a pull request from BramBauwens:ticket/master/fact-1268-ec2_connection_timeout into puppetlabs:master. I assumed from what I have read in the CONTRIBUTING.md that master is the correct branch to merge to.

Any help would be appreciated! :-)

Bram

edit retag flag offensive close merge delete

1 Answer

Sort by ยป oldest newest most voted
0

answered 2017-04-20 18:21:38 -0500

geoff gravatar image

Hi Bram,

It looks like your pull request was fine. The mingw-w64 not installed error was related to an intermittent issue with a Windows packaging host used in the PR test.

Thanks for your contribution!

edit flag offensive delete link more

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

1 follower

Stats

Asked: 2017-04-19 06:54:09 -0500

Seen: 24 times

Last updated: Apr 19